Skip to content

Conversation

@alexeagle
Copy link
Contributor

…hProviders

Ivy depends on having the generic type token later when reading the ModuleWithProviders from a .d.ts file.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@alexeagle alexeagle requested a review from alxhub September 14, 2018 21:58
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Sep 14, 2018
@mary-poppins
Copy link

You can preview b9ff138 at https://pr25970-b9ff138.ngbuilds.io/.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Sep 14, 2018
…hProviders

Ivy depends on having the generic type token later when reading the ModuleWithProviders from a .d.ts file.
@mary-poppins
Copy link

You can preview 05454b2 at https://pr25970-05454b2.ngbuilds.io/.

@benlesh benlesh closed this in cbbad1b Sep 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants