Skip to content

Conversation

@dlo
Copy link

@dlo dlo commented Oct 18, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Issue template update.

What is the current behavior?

There was a missing 's'.

What is the new behavior?

Now the 's' is no longer missing.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

❤️

@brandonroberts brandonroberts self-assigned this Oct 18, 2018
@brandonroberts brandonroberts added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Oct 18, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 18, 2018
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the git commit message to docs: fix minor typo on issue template

@brandonroberts
Copy link
Contributor

Thanks for the PR @dlo! I left you some feedback.

Once that change is made, its reviewed and approved, and is green on CI it will be ready to merge.

@dlo
Copy link
Author

dlo commented Oct 18, 2018

@brandonroberts just updated. :)

@brandonroberts brandonroberts added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 18, 2018
brandonroberts
brandonroberts approved these changes Oct 18, 2018
@brandonroberts
Copy link
Contributor

Thanks for the PR @dlo! The issue templates are being completely redone here #26918, so this one is no longer needed. If you see something else, feel free to open a new PR.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants