Skip to content

docs(router): route alias has to be written in PascalCase #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs(router): route alias has to be written in PascalCase #4547

wants to merge 1 commit into from

Conversation

@0x-r4bbit
Copy link
Contributor

@0x-r4bbit 0x-r4bbit commented Oct 6, 2015

No description provided.

@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Oct 7, 2015
@mary-poppins
Copy link

mary-poppins commented Oct 7, 2015

Merging PR #4547 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4547.

1 similar comment
@mary-poppins
Copy link

mary-poppins commented Oct 7, 2015

Merging PR #4547 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4547.

@mary-poppins mary-poppins removed action: merge The PR is ready for merge by the caretaker labels Oct 7, 2015
@IgorMinar IgorMinar self-assigned this Oct 7, 2015
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2015
@mary-poppins
Copy link

mary-poppins commented Oct 7, 2015

Merging PR #4547 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4547.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 7, 2015
@btford btford added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@mary-poppins
Copy link

mary-poppins commented Oct 9, 2015

Merging PR #4547 on behalf of @btford to branch presubmit-btford-pr-4547.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 9, 2015
@btford
Copy link
Contributor

btford commented Oct 9, 2015

Let's try once more... @_@

@btford
Copy link
Contributor

btford commented Oct 9, 2015

Had to manually push, here's the presubmit: https://travis-ci.org/angular/angular/builds/84432124

@btford btford closed this in cd2050b Oct 9, 2015
@0x-r4bbit
Copy link
Contributor Author

0x-r4bbit commented Oct 11, 2015

Thanks Brian!

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@IgorMinar IgorMinar

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0x-r4bbit @mary-poppins @btford @IgorMinar @googlebot