Fix importProvidersFrom interaction with ModuleWithProviders #45722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
AndrewKushnir,
atscott,
dylhunn and
jessicajaniuk
There was a problem hiding this comment.
@alxhub looks great, just a couple comments with additional use-cases to consider.
AndrewKushnir
added
action: review
|
@alxhub FYI I've addressed the comments and pushed a couple fixup commits. This PR is ready for review. // cc @pkozlowski-opensource |
AndrewKushnir
force-pushed
the
standalone-import-mwp
branch
from
cf3aee2 to
0494b68
Compare
AndrewKushnir
force-pushed
the
standalone-import-mwp
branch
from
0494b68 to
6de6893
Compare
jessicajaniuk
approved these changes
Apr 22, 2022
atscott
approved these changes
Apr 22, 2022
alfaproject
reviewed
Apr 23, 2022
This commit moves the ModuleWithProviders type from `metadata` to `di`, avoiding the need for `di` to reference `metadata` (in this particular case).
…idersFrom` There were two problems with the `importProvidersFrom` function related to `ModuleWithProviders` values: * The public type did not accept `ModuleWithProviders` values directly. * The implementation of `walkProviderTree` delegates collection of MWP providers to its caller, in order for the ordering of such providers to be correct. However, `importProvidersFrom` was not performing that collection, causing MWP providers passed in at the top level to be dropped.
…ortProvidersFrom`
AndrewKushnir
force-pushed
the
standalone-import-mwp
branch
from
6de6893 to
1ed66c6
Compare
AndrewKushnir
approved these changes
Apr 27, 2022
AndrewKushnir
added
action: global presubmit
AndrewKushnir
added
action: presubmit
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit 882f595. |
atscott
pushed a commit
that referenced
this pull request
Apr 27, 2022
…idersFrom` (#45722) There were two problems with the `importProvidersFrom` function related to `ModuleWithProviders` values: * The public type did not accept `ModuleWithProviders` values directly. * The implementation of `walkProviderTree` delegates collection of MWP providers to its caller, in order for the ordering of such providers to be correct. However, `importProvidersFrom` was not performing that collection, causing MWP providers passed in at the top level to be dropped. PR Close #45722
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with the
importProvidersFromfunction related toModuleWithProvidersvalues:ModuleWithProvidersvalues directly.walkProviderTreedelegates collection of MWP providersto its caller, in order for the ordering of such providers to be correct.
However,
importProvidersFromwas not performing that collection, causing MWPproviders passed in at the top level to be dropped.