Skip to content

Aio home a11y improvements #45740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Aio home a11y improvements #45740

wants to merge 5 commits into from

Conversation

@dario-piotrowicz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Issue

Issue Number: N/A

What is the new behavior?

Some simple a11y improvements in the aio home page

Does this PR introduce a breaking change?

  • Yes
  • No

dario-piotrowicz
dario-piotrowicz commented Apr 23, 2022
View reviewed changes
aio/content/marketing/index.html Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot at 2022-04-23 22-19-10

dario-piotrowicz
dario-piotrowicz commented Apr 23, 2022
View reviewed changes
aio/content/marketing/index.html Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this and the rest of the images, I think these are clearly decorative images so I think they should have an empty alt value (https://www.w3.org/WAI/tutorials/images/decorative/)

@dario-piotrowicz
docs: make sure aio home has a non-ignored h1
72bb57a 
currently the aio home page presents a single h1 which is ignored by
assistive technologies since it has its display set none, so replace it
with a new h1 containing the main text of the page instead
@dario-piotrowicz
docs: use proper sections in aio home
e7cc513 
convert the `div` groups in the aio home page
to proper `section`s with a valid heading/title
@dario-piotrowicz
docs: empty alt of aio home decorative images
5391fb5 
in the aio home page the sections' decorative images provide an alt
texts, which shouldn't actually be present
(see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such
alt text for a better user experience
@dario-piotrowicz dario-piotrowicz force-pushed the aio-home-a11y-improvements branch from 26561f8 to 5391fb5 Compare April 23, 2022 21:22
@dario-piotrowicz
Copy link
Contributor Author

@gkalpak I was about to create a single commit again, but I made sure to split it into 3 clear self contained commits, I hope that's fine 😃 (even though each commit is very very small)

dario-piotrowicz
dario-piotrowicz commented Apr 23, 2022
View reviewed changes
mgechev
mgechev approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely to see these changes!

@pullapprove pullapprove bot requested a review from alxhub April 25, 2022 17:55
@gkalpak gkalpak added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra target: patch This PR is targeted for the next patch release labels Apr 27, 2022
@mary-poppins
Copy link

You can preview 5391fb5 at https://pr45740-5391fb5.ngbuilds.io/.
You can preview 29f1b31 at https://pr45740-29f1b31.ngbuilds.io/.

@ngbot ngbot bot modified the milestone: Backlog Apr 27, 2022
@gkalpak gkalpak self-requested a review April 27, 2022 10:54
gkalpak
gkalpak requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @dario-piotrowicz 💯
Just a couple of minor comments.

I love the self-contained commits 😉

@dario-piotrowicz dario-piotrowicz force-pushed the aio-home-a11y-improvements branch from 2e3edb4 to e2754fb Compare April 27, 2022 12:04
@dario-piotrowicz
fixup! docs: make sure aio home has a non-ignored h1
594241c 
refactor `!noTitle` to `needsTitle`
@dario-piotrowicz dario-piotrowicz force-pushed the aio-home-a11y-improvements branch from e2754fb to 594241c Compare April 27, 2022 12:06
@mary-poppins
Copy link

You can preview 594241c at https://pr45740-594241c.ngbuilds.io/.

@gkalpak gkalpak removed the request for review from alxhub April 27, 2022 12:49
@gkalpak gkalpak removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 27, 2022
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Apr 27, 2022
@gkalpak gkalpak modified the milestones: Backlog, docs-infra-aio-app Apr 27, 2022
@atscott
Copy link
Contributor

atscott commented Apr 27, 2022

This PR was merged into the repository by commit 7d8998c.

@atscott atscott closed this in d1a9fd5 Apr 27, 2022
atscott pushed a commit that referenced this pull request Apr 27, 2022
@dario-piotrowicz @atscott
docs: use proper sections in aio home (#45740)
a895da6 
convert the `div` groups in the aio home page
to proper `section`s with a valid heading/title

PR Close #45740
atscott pushed a commit that referenced this pull request Apr 27, 2022
@dario-piotrowicz @atscott
docs: empty alt of aio home decorative images (#45740)
7d8998c 
in the aio home page the sections' decorative images provide an alt
texts, which shouldn't actually be present
(see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such
alt text for a better user experience

PR Close #45740
atscott pushed a commit that referenced this pull request Apr 27, 2022
@dario-piotrowicz @atscott
docs: make sure aio home has a non-ignored h1 (#45740)
b838b4c 
currently the aio home page presents a single h1 which is ignored by
assistive technologies since it has its display set none, so replace it
with a new h1 containing the main text of the page instead

PR Close #45740
atscott pushed a commit that referenced this pull request Apr 27, 2022
@dario-piotrowicz @atscott
docs: use proper sections in aio home (#45740)
bed3362 
convert the `div` groups in the aio home page
to proper `section`s with a valid heading/title

PR Close #45740
atscott pushed a commit that referenced this pull request Apr 27, 2022
@dario-piotrowicz @atscott
docs: empty alt of aio home decorative images (#45740)
73fda73 
in the aio home page the sections' decorative images provide an alt
texts, which shouldn't actually be present
(see: https://www.w3.org/WAI/tutorials/images/decorative/), empty such
alt text for a better user experience

PR Close #45740
@dario-piotrowicz dario-piotrowicz deleted the aio-home-a11y-improvements branch April 27, 2022 16:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mgechev mgechev mgechev approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

docs-infra-aio-app

Development

Successfully merging this pull request may close these issues.

5 participants

@dario-piotrowicz @mary-poppins @atscott @mgechev @gkalpak