Skip to content

Conversation

@pkozlowski-opensource
Copy link
Member

This refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning:

  • attribute and property names are not always equal (ex. in a template we want to write <input read-only="exp"> while the corresponding property binding should be readOnly)
  • people want to express directive selectors as targeting normalized attribute name (ex.: for an element like <input [read-only]="exp">, <input bind-read-only="exp"> I want to always express my attribute selector as [read-only])

@pkozlowski-opensource
Copy link
Member Author

This is pre-requisite for fixing #866

@mhevery I hope that his is the change you had on your mind during yesterday's discussion.

@pkozlowski-opensource
Copy link
Member Author

@tbosch this is the PR I've mentioned during the stand-up. Please ping me if you need any additional info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove propertyBindings from createPipeline in this spec (clean up) and move this test up into integratation_spec.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove variableBindings, this should follow the same rules as propertyBindings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same there, move one of the tests for variableBindings up into integration_spec

@tbosch tbosch added @lgtm action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 12, 2015
This alligns with JS-version behaviour
@pkozlowski-opensource pkozlowski-opensource force-pushed the match_by_attrs branch 4 times, most recently from 095e530 to d38abc6 Compare March 13, 2015 15:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants