-
Notifications
You must be signed in to change notification settings - Fork 26.7k
refactor: use attributes for directives matching #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use attributes for directives matching #940
Conversation
359a339 to
a601172
Compare
|
@tbosch this is the PR I've mentioned during the stand-up. Please ping me if you need any additional info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove propertyBindings from createPipeline in this spec (clean up) and move this test up into integratation_spec.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove variableBindings, this should follow the same rules as propertyBindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same there, move one of the tests for variableBindings up into integration_spec
This alligns with JS-version behaviour
095e530 to
d38abc6
Compare
d38abc6 to
90e56b6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning:
<input read-only="exp">while the corresponding property binding should bereadOnly)<input [read-only]="exp">,<input bind-read-only="exp">I want to always express my attribute selector as[read-only])