Skip to content

authState observable does not use injected app #907

@cartant

Description

@cartant

Version info

Angular: N/A

Firebase: N/A

AngularFire: Current master

Other (e.g. Ionic/Cordova, Node, browser, operating system): N/A

This issue doesn't relate to a bug that should need to be reproduced. Rather, the problem should be apparent be reading the source code - which was how it was found.

This commit efc67c5 saw the implementation of the authState observable. However, there is a problem with it. If you look at this line:

firebase.auth().onAuthStateChanged(

It's obvious that the (injected) app passed to the function is not used and the default Firebase app is used instead. The line should be:

app.auth().onAuthStateChanged(

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions