Skip to content

Conversation

@mhartington
Copy link
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
    Specific docs for Ionic and Ionic CLI #1003
  • Docs included?: (yes/no; required for all API/functional changes)
    Yes
  • Test units included?: (yes/no; required)
    No, N/A
  • e2e tests included?: (yes/no; required for multi-function/multi-class changes)
    No, N/A
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)
    Yes

Description

Fix for #1003. Added section an link to a specific Ionic/Ionic CLI installation and setup.

Code sample

N/A

Copy link
Contributor

@markgoho markgoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the Firebase config to use the environment.ts file that is demonstrated in the initial setup? We need to be consistent about how folks should be adding their config information.

@mhartington
Copy link
Contributor Author

Ionic's CLI does not generate a environment.ts by default, so users would have to make that themselves. I can add that though.

@thorizer
Copy link

thorizer commented Jun 2, 2017

@mhartington thanks a lot for the updated docs ! there is something missing thought .
What if I want to implement firebase as a provider not just inside home.ts .

@jamesdaniels jamesdaniels merged commit 123569e into angular:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants