Skip to content

fix(FirebaseListFactory): prevent first item being duplicated when it… #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2016
Merged

fix(FirebaseListFactory): prevent first item being duplicated when it… #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/utils/firebase_list_factory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ describe('FirebaseListFactory', () => {
).toEqual([val2, val1, val3]);
});

it('should not duplicate the first item if it is the one that changed', () => {
expect(
onChildChanged([val1, val2, val3], val1, null)
).not.toEqual([val1, val1, val2, val3]);
});

it('should not mutate the input array', () => {
var inputArr = [val1, val2];
Expand Down
4 changes: 3 additions & 1 deletion src/utils/firebase_list_factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ export function onChildChanged(arr:any[], child:any, prevKey:string): any[] {
return arr.reduce((accumulator:any[], val:any, i:number) => {
if (!prevKey && i==0) {
accumulator.push(child);
accumulator.push(val);
if (val.key() !== child.key()) {
accumulator.push(val);
}
} else if(val.key() === prevKey) {
accumulator.push(val);
accumulator.push(child);
Expand Down