Skip to content

Conversation

@jamesdaniels
Copy link
Member

Checklist

Description

Adding user and idTokenResult to AngularFireAuth.

Copy link

@markstuart markstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like that the user subscription will fire for all auth events and that you are recommending its use instead of authState.

👍

Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesdaniels jamesdaniels merged commit 31045a9 into master May 14, 2018
@jamesdaniels jamesdaniels deleted the auth_additions branch May 14, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants