Skip to content

docs(): minor typo fixes #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2018
Merged

docs(): minor typo fixes #1743

merged 2 commits into from
Aug 15, 2018

Conversation

@EdricChan03
Copy link
Contributor

@EdricChan03 EdricChan03 commented Jun 22, 2018

Checklist

  • Issue number for this PR: none
  • Docs included?: yes
  • Test units included?: no
  • In a clean directory, yarn install, yarn test run successfully?: yes

Description

  • This pull request updates all of the documentation to be more consistent.
  • Also updates the naming of "angular-cli" to "Angular CLI" and from the now outdated angular-cli package to @angular/cli.

@EdricChan03
Copy link
Contributor Author

EdricChan03 commented Jul 12, 2018

/cc @davideast Could you take a look?

davideast
davideast approved these changes Aug 15, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for these fixes! I'll merge once the CI finishes.

@davideast davideast merged commit 8f95852 into angular:master Aug 15, 2018
sulco pushed a commit to sulco/angularfire2 that referenced this pull request Sep 3, 2018
@EdricChan03 @sulco
docs(): minor typo fixes (angular#1743)
b302d80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

+1 more reviewer

@nishchay7pixels nishchay7pixels nishchay7pixels approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EdricChan03 @davideast @nishchay7pixels @googlebot