Skip to content

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Aug 22, 2018

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Since Functions is undocumented, I thought I'd take a pass on making it lazy too. This requires #1832 be merged to pass.

Code sample

@jamesdaniels jamesdaniels changed the title WIP lazy AngularFireFunctions feat(functions): lazy AngularFireFunctions Aug 23, 2018
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels
Copy link
Member Author

Going to punt on this for now; since dynamic imports aren't supported by StackBlitz, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants