Skip to content

chore(): angularfire2 shim #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2018
Merged

chore(): angularfire2 shim #1864

merged 4 commits into from
Sep 11, 2018

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Sep 7, 2018 •
edited
Loading

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

This is currently deployed [email protected].

Code sample

davideast
davideast approved these changes Sep 11, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels jamesdaniels merged commit 1bd8dbb into master Sep 11, 2018
@jamesdaniels jamesdaniels deleted the legacy_wrapper branch September 11, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesdaniels @davideast @googlebot