Skip to content

Conversation

@asgarli
Copy link
Contributor

@asgarli asgarli commented Sep 17, 2018

This is done do that we don't include all of firebase library, and the final bundle is smaller.

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

This is done do that we don't include all of firebase library, and the final bundle is smaller.
@asgarli
Copy link
Contributor Author

asgarli commented Sep 17, 2018

Based on #1879

@jamesdaniels jamesdaniels merged commit 2be50c7 into angular:master Sep 21, 2018
@jamesdaniels
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants