Skip to content

Conversation

@jamesdaniels
Copy link
Member

Checklist

Description

  • Changelogs and version bumps
  • .bind() the messaging callbacks
  • Another bug! onTokenRefresh doesn't actually return the token, just fires when you need to get it

Code sample

@jamesdaniels
Copy link
Member Author

Available here for testing @angular/fire 5.0.2.

@jamesdaniels
Copy link
Member Author

FYI @codediodeio

Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davideast davideast merged commit 9293dc6 into master Sep 21, 2018
@davideast davideast deleted the bind_messaging branch September 21, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants