Skip to content

Add StorageBucket injection token to storage docs #1958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2018
Merged

Add StorageBucket injection token to storage docs #1958

merged 1 commit into from
Nov 21, 2018

Conversation

@thomastoye
Copy link
Contributor

Checklist

Description

Added short StorageBucket example to storage docs.

davideast
davideast approved these changes Nov 21, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomastoye Thank you so much!

@davideast davideast merged commit b91cd5a into angular:master Nov 21, 2018
peterennis added a commit to peterennis/angularfire2 that referenced this pull request Jan 3, 2019
@peterennis
Merge pull request #19 from angular/master
2e4f6fd 
Add StorageBucket injection token to storage docs (angular#1958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomastoye @davideast @googlebot