-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: exception while running command ng deploy (#2088) #2221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When we execute `ng deploy` command, `workspace.root` gives wrong path in Windows environment, thats why it doesn't work in Windows environment. Using only `project root` In `getFirebaseProjectName` and `deploy`, will successfully allow `ng deploy` while executing it at project root in windows and linux environment. fixes angular#2088
|
@NothingEverHappens, Thanks for the approval. |
|
@ngdevelop-tech Meanwhile you can try running |
NothingEverHappens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing it locally yesterday I'm not convinced this is the best solution.
I think the culprit is the normalize function which we should use in a platform aware way.
@NothingEverHappens Sorry for the delayed reply, I will look into solving this with a better approach. |
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
When we execute
ng deploycommand,workspace.rootgives the wrong path in the Windows environment, that's why it doesn't work in the Windows environment.Using only
project rootIngetFirebaseProjectNameanddeploy, will successfully allowng deploywhile executing it at project root in windows and linux environment.fixes #2088