Skip to content

Conversation

@junaidahmed501
Copy link

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

When I was adding firebase into my angular app following the exact steps that are mentioned in this repo's readme, I still had problem running my project because I somehow missed installation of firebase & it took me some time to figure it out after a lot of searching. Although it is mentioned in the readme doc file about the installation of firebase from npm, it's not too clear so that's what I've tried to add.
Apologies in advance if I've missed the guidelines but I've tried my best though.

Code sample

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@junaidahmed501
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jamesdaniels
Copy link
Member

Firebase npm install is fixed with #2485, maybe we should state what the ng add command did for the developer?

@jamesdaniels
Copy link
Member

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants