Skip to content

fix(afs): fixing the metadata in snapshotChanges and more #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2020
Merged

fix(afs): fixing the metadata in snapshotChanges and more #2670

merged 3 commits into from
Nov 19, 2020

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 19, 2020

  • metadata updates weren't getting to the snapshotChanges on collections due to docChanges() not including metadata in the changes, even when you ask for it
  • pull spliceAndSlice from rxfire and use it in combination with distinctUntilChanged() to reduce unneeded change detection cycles
  • added some more stuff to my sample app

@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@jamesdaniels jamesdaniels merged commit d5dbe99 into master Nov 19, 2020
@jamesdaniels jamesdaniels deleted the fix_afs_metadata branch November 19, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jamesdaniels