Skip to content

Conversation

@Tommertom
Copy link

I think we all love Angular and if there is an Angular-ish way of using service workers together with this great AngularFire package, it should be noted here. Initially I got really stuck figuring out workbox. While it is very powerfull, but also time consuming. So I recommend giving the reader a bit more comfort about the potential/opportunities using AngularFire.

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

I think we all love Angular and if there is an Angular-ish way of using service workers together with this great AngularFire package, it should be noted here. Initially I got really stuck figuring out workbox. While it is very powerfull, but also time consuming. So I recommend giving the reader a bit more comfort about the potential/opportunities using AngularFire.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jan 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 5, 2021
@Tommertom
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jan 5, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 5, 2021
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good change

@jamesdaniels jamesdaniels merged commit 36666b6 into angular:master Jan 12, 2021
@Tommertom
Copy link
Author

@jamesdaniels I see I made typos.. Sorry about that. You can correct directly or you want me to do a PR? What is most convenient for you...

Two small typos:

  • forgot closing . in - 'If you are using the Angular Service Worker, you are not currently able to use AngularFireMessaging out-of-the-box'
  • double this in "Following the discussion in this [this...]

Apologies again.

@jamesdaniels
Copy link
Member

No worries. Feel free to send a PR.

@Tommertom Tommertom deleted the patch-1 branch January 13, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants