Skip to content

WIP: AngularFire Guide #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 10, 2021
Merged

WIP: AngularFire Guide #2754

merged 8 commits into from
Feb 10, 2021

Conversation

@davideast
Copy link
Collaborator

@davideast davideast commented Feb 8, 2021 •
edited
Loading

A docs site!

We are working on an early stage docs site! There's lots of things left to fix, but it has most of the existing documentation and in a format that's easier to navigate.

Early Preview

Stage 1

  • Set up basic responsive layout
  • Migrate content from docs/ to site/

Stage 2

Wont be addressed with this PR

  • Fix text sizing and spacing issues
  • Break apart CSS files from the mega CSS file
  • Update old documentation
  • Set up Preview Channels for easy collaboration

Stage 3

Wont be addressed with this PR

  • Add a snazzy landing page!
  • Expand documentation sections
  • Add recipes/tutorials

jamesdaniels
jamesdaniels approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels
Copy link
Member

jamesdaniels commented Feb 9, 2021

Great start.

@jamesdaniels
Copy link
Member

jamesdaniels commented Feb 9, 2021

@davideast Nit. Make sure your .gitignore is ignoring caches and generated assets.

@davideast
Copy link
Collaborator Author

davideast commented Feb 10, 2021

@davideast Nit. Make sure your .gitignore is ignoring caches and generated assets.

I want to try seeing what affect having the .firebase cache in source has for deployments. As the site grows I think it can help. If it janks things up I'll remove it.

@davideast davideast merged commit a26676c into master Feb 10, 2021
@davideast davideast deleted the site branch February 10, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davideast @jamesdaniels @googlebot