Skip to content

Conversation

@caroso1222
Copy link
Contributor

As for the latest angularcli@webpack release, the app.module.ts should be the file you must edit to import the Firebase provider. You're also exporting MyAppModule class and not bootstraping any module as a main.ts would do so it must be app.module.ts.

As for the latest angularcli@webpack release, the app.module.ts should be the file you must edit to import the Firebase provider. You're also exporting MyAppModule class and not bootstraping any module so it must be app.module.ts.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@caroso1222
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@davideast
Copy link
Collaborator

@caroso1222 Thanks for the PR!

@davideast davideast merged commit c1642ca into angular:master Aug 26, 2016
@caroso1222 caroso1222 deleted the patch-1 branch August 26, 2016 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants