Upgrade to RC7 #505
Merged
Upgrade to RC7 #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbcross
reviewed
Sep 14, 2016
package.json
Outdated
| "@angular/core": "^2.0.0-rc.5", | ||
| "@angular/platform-browser": "^2.0.0-rc.5", | ||
| "@angular/platform-browser-dynamic": "^2.0.0-rc.5", | ||
| "@types/bluebird": "^3.0.32", |
There was a problem hiding this comment.
Why bluebird types? We're not using bluebird library
| firebase: 'node_modules/firebase/firebase.js', | ||
| 'app': 'dist' | ||
| 'app': 'dist', | ||
| '@angular/core': 'npm:@angular/core/bundles/core.umd.js', |
There was a problem hiding this comment.
Can SystemJS load the ES modules instead, using the old configuration but adding format: 'esm'?
karma.conf.js
Outdated
| {pattern: 'karma-test-shim.js', included: true, watched: true}, | ||
| {pattern: 'built/test/matchers.js', included: true, watched: true}, | ||
| { pattern: 'karma-test-shim.js', included: true, watched: true }, | ||
| //{ pattern: 'dist/test/matchers.js', included: true, watched: true }, |
package.json
Outdated
| "@angular/core": "^2.0.0-rc.5", | ||
| "@angular/platform-browser": "^2.0.0-rc.5", | ||
| "@angular/platform-browser-dynamic": "^2.0.0-rc.5", | ||
| "@types/bluebird": "^3.0.32", |
There was a problem hiding this comment.
Why do we need these types if we're not using Bluebird?
There was a problem hiding this comment.
That should be gone. Needed it for debugging.
src/test-config.ts
Outdated
| export const ANON_AUTH_CONFIG = { | ||
| method: AuthMethods.Anonymous, | ||
| provider: AuthProviders.Anonymous | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #468 #493 #499 #502
And hopefully some auth issues too #496