-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update Pre-requisities and troubleshooting section #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated troubleshooting section to notify the "require" error, while invoking ng serve and modified pre-requisites section to update the order in which angular-cli version is checked.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
davideast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @mukesh51! Just two tiny little comments and it's good to go after the CLA is signed.
|
|
||
| #### 2. Cannot find name 'require'. | ||
|
|
||
| If you run into this error while trying to invoke `ng serve`, open `src/typings.d.ts` and add the following two entries as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add that this is just a temporary workaround for the Angular CLI?
docs/1-install-and-setup.md
Outdated
| npm install -g angular-cli@webpack | ||
| ``` | ||
|
|
||
| You need the Angular CLI (you already got above), typings, and TypeScript 2.0. TypeScript 2.0 is required for AngularFire2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(you already got above)
Remove that part as it's a bit redundant.
Updated the document as per David's comments.
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
Updated troubleshooting section to notify the "require" error, while invoking ng serve and
modified pre-requisites section to update the order in which angular-cli version is checked.