Skip to content

Conversation

@fisherds
Copy link
Contributor

@fisherds fisherds commented May 4, 2017

Copied some material from #854 into this doc

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • e2e tests included?: (yes/no; required for multi-function/multi-class changes)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

Code sample

Copied some material from angular#854 into this doc
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change! Just a small bit about clarifying the NgModule imports.

@NgModule({
imports: [
BrowserModule,
AngularFireModule.initializeApp(firebaseConfig, 'my-app-name'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment for each line saying what it adds in terms of Firebase, just so we can help those that hastily copy and paste.

AngularFireModule.initializeApp(firebaseConfig, 'my-app-name'), // imports firebase/app needed for everything
AngularFireDatabaseModule, // imports firebase/database, only needed for database features
AngularFireAuthModule, // imports firebase/auth, only needed for auth features

@fisherds
Copy link
Contributor Author

fisherds commented May 4, 2017

Love the additions Dave. I signed the CLA btw. I also used to work at Google so hopefully I'm trustworthy enough. ;)

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 4, 2017
@davideast davideast merged commit 85ae252 into angular:master May 4, 2017
@davideast
Copy link
Collaborator

Thanks @fisherds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants