-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add information about individual @NgModules #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copied some material from angular#854 into this doc
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this change! Just a small bit about clarifying the NgModule imports.
docs/1-install-and-setup.md
Outdated
| @NgModule({ | ||
| imports: [ | ||
| BrowserModule, | ||
| AngularFireModule.initializeApp(firebaseConfig, 'my-app-name'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for each line saying what it adds in terms of Firebase, just so we can help those that hastily copy and paste.
AngularFireModule.initializeApp(firebaseConfig, 'my-app-name'), // imports firebase/app needed for everything
AngularFireDatabaseModule, // imports firebase/database, only needed for database features
AngularFireAuthModule, // imports firebase/auth, only needed for auth features|
Love the additions Dave. I signed the CLA btw. I also used to work at Google so hopefully I'm trustworthy enough. ;) |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Thanks @fisherds! |
Copied some material from #854 into this doc
Checklist
npm install,npm run build, andnpm testrun successfully? (yes/no; required)Description
Code sample