Skip to content

Conversation

@markgoho
Copy link
Contributor

@markgoho markgoho commented May 5, 2017

Checklist

  • Issue number for this PR: n/a
  • Docs included?: yes, this is a doc change
  • Test units included?: no
  • e2e tests included?: no
  • In a clean directory, npm install, npm run build, and npm test run successfully? yes

Description

I'm adding this change to the initial setup of AngularFire2 whereby the environment.ts file is used for config instead of putting it in the app.module.ts file itself.

This change brings the setup docs into parity with Upgrade Guide where the environment.ts file is referenced but never actually explained.

Code sample

n/a

@davideast
Copy link
Collaborator

Thanks again, @markgoho! You're coming in clutch 💥

@davideast davideast merged commit e35cd24 into angular:master May 5, 2017
@markgoho markgoho deleted the patch-1 branch May 5, 2017 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants