-
Notifications
You must be signed in to change notification settings - Fork 6.8k
demo(youtube-player): add auto video resizing #17648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Splaktar
commented
Nov 7, 2019
- automatically resize the video to fit the screen
- this was noticeable on mobile where the video would just get cut off
- rename video to selectedVideo for clarity
- fix TypeScript path mappings so that IDEs don't complain about module
- use classes to style Material components as recommended
I wonder if this is highlighting a bigger problem with the component: most users would expect the youtube video to fill the width of the youtube-player element. Rather than forcing the user to explicitly set a width and height, I wonder if it should default to whatever the css style of the youtube-player element. |
@YourDeveloperFriend I do think that there is a case for a fixed size API, but I agree that there also should be some kind of |
- automatically resize the video to fit the screen - this was noticeable on mobile where the video would just get cut off - rename video to selectedVideo for clarity - fix TypeScript path mappings so that IDEs don't complain about module - use classes to style Material components as recommended
242f19c
to
5254796
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reminds me that I want to make a StackBlitz of this demo running and link to it from here
@jelbourn here's a StackBlitz of this demo. Did you just want to link it from this PR or from the README of the YouTube Player component? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |