perf(material/form-field): set notch outline variable only on relevant element #30955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
angular-robot
bot
added
area: performance
…t element We were setting the `--mat-form-field-notch-max-width` on the entire form field which can cause style recalculations. These changes move to the relevant element only.
crisbeto
force-pushed
the
notch-variable
branch
from
134f54c to
fe732a1
Compare
andrewseguin
approved these changes
Apr 25, 2025
| var(--mat-form-field-notch-max-width, 100%), | ||
| calc(100% - max(12px, #{$shape-var}) * 2) | ||
| ); | ||
| max-width: min(var(--mat-form-field-notch-max-width, 100%), #{$min-value}); |
There was a problem hiding this comment.
--mat-form-field-notch-max-width looks like a token, but I assume its just internal-only. Seems like we should have a different shape of variables that are private. Like --_mat_private- or something
There was a problem hiding this comment.
Yeah not really a token, just an implementation detail.
crisbeto
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting the
--mat-form-field-notch-max-widthon the entire form field which can cause style recalculations. These changes move to the relevant element only.