fix(cdk/table): remove private symbols from public API #30956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some symbols that are only constructed privately in the table from the public API. These shouldn't be exported or depended upon, because there's no way to actually pass them back into the table. I also ended up removing the `CDK_TABLE_TEMPLATE` variable, because it doesn't work in local compilation and it may become a problem in the future if we end up having single-file compilation in the framework. BREAKING CHANGE: * `CanStick` has been removed. * `CDK_TABLE_TEMPLATE` has been removed. * `StickyDirection` has been removed. * `StickyStyler` has been removed.
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
angular-robot
bot
added
detected: breaking change
andrewseguin
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some symbols that are only constructed privately in the table from the public API. These shouldn't be exported or depended upon, because there's no way to actually pass them back into the table.
I also ended up removing the
CDK_TABLE_TEMPLATEvariable, because it doesn't work in local compilation and it may become a problem in the future if we end up having single-file compilation in the framework.BREAKING CHANGE:
CanStickhas been removed.CDK_TABLE_TEMPLATEhas been removed.StickyDirectionhas been removed.StickyStylerhas been removed.