Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

@feelingsofwhite
Copy link
Contributor

these code changes are based on code found in the angular docs component with external testing downloadable example.

Although the refactoring I described in #444 seems pretty simple enough to understand, In my fork you can see branches demonstrate-bug-444 & demonstrate-fix-444 for more context of this bug and how this fix it.

I'm assuming because this code came from elsewhere in angular help/tutorial that it's okay.. but as a sidenote, the "indexof('moduleId')" seems rather poor because if you've got the word "moduleId" anywhere (for example, in a line of sourcecode you just commented out) it, the module fails to load the template. Not sure what the better solution would be, just my $0.02

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@feelingsofwhite
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss
Copy link
Member

Thanks. I am responsible for the changes but I forgot to update it here.

Yes, the indexOf is not the best solution, but does the trick for now.

@Foxandxss Foxandxss merged commit 87ad8f5 into angular:master Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants