Skip to content

Feature/diet for images #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

flexbox
Copy link
Contributor

@flexbox flexbox commented Oct 2, 2024

2 things

  1. update all images to load them faster
    image
  2. migrate HTML tags to View, Text and Button from react-native core

@anisurrahman072
Copy link
Owner

Incredible amount of work you put in here. I appreciate your time once again 🔥

  • I especially love the Image optimizations. So far, I understand that you downgrade the image sizes. Does that sound correct?

  • Thanks you corrected some spelling mistakes too 🤟

  • Just one point, I'm a bit concerned. Code still has some <h1> <h2> etc HTML tags. Also, do you have any comments about importing <View>, <Text> etc? As readers may not understand, from where those are coming. Or we may mention in a side NOTE that those are from the react-native core.

@anisurrahman072 anisurrahman072 self-requested a review October 2, 2024 16:03
@flexbox
Copy link
Contributor Author

flexbox commented Oct 2, 2024

@anisurrahman072 the name of the book is "React-Native-Advanced-Guide" so I believe they will catch up, if not they can google stuff.

✅ migrated h1, h2 to Text

@anisurrahman072 anisurrahman072 merged commit 69d2091 into anisurrahman072:master Oct 2, 2024
@anisurrahman072 anisurrahman072 self-assigned this Oct 2, 2024
@flexbox flexbox deleted the feature/diet-for-images branch October 3, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants