-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[DO NOT MERGE] Removed < 1.66 for grpcio #34196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL at test/lint errors.
Co-authored-by: tvalentyn <[email protected]>
.github/workflows/beam_PreCommit_Python_Coverage.yml https://github.com/apache/beam/actions/runs/13738774760/job/38433034429?pr=34196 [gw5] [ 97%] FAILED apache_beam/runners/portability/portable_runner_test.py::PortableRunnerTestWithSubprocesses::test_combine_per_key |
https://github.com/apache/beam/actions/runs/13738774755/job/38433041471?pr=34196
|
Also launched GoPortable presubmit suite on these changes: https://github.com/apache/beam/actions/runs/13814130500 That is the suite that was previously failing on new versions of grpc. |
|
https://github.com/apache/beam/actions/runs/13814130500/job/38824779287 also keeps failing. |
1.71: still timeout for many tests. |
Reminder, please take a look at this pr: @jrmccluskey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
Mark this as a blocker for Beam 2.65.0. |
Reminder, please take a look at this pr: @damccorm |
blocked by grpc/grpc#39113 |
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
note: there may be additional, yet to be studied issue in grpc 1.66.0., the original reason why the upper bound was introduced. |
is this still targeted to 2.65.0 ? cc: @liferoad @tvalentyn |
We can merge this after the Beam 2.64.0 release cut on March 19 to check whether grpcio still causes issues.
Fixes #34081
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.