-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[KafkaIO] Improve caching in backlog estimation and processing #34331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[KafkaIO] Improve caching in backlog estimation and processing #34331
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
e002e0d
to
291409e
Compare
291409e
to
1cb05c9
Compare
Any updates ? |
@kennknowles @shunping or @Dippatel98 PTAL |
ACK - this change will take me some time to grok |
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java
Show resolved
Hide resolved
Reminder, please take a look at this pr: @kennknowles @shunping @Dippatel98 |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @ahmedabu98 for label java. Available commands:
|
Hey @sjvanrossum, are you still working on this? |
@ahmedabu98 I just pushed a requested docs change and a fix for a bug I spotted earlier, otherwise this is ready. |
@johnjcasey @ahmedabu98 I've addressed the integration test failure in #34711. |
@johnjcasey it looks like #34711 fails as a separate PR, but succeeds as part of this PR so I've added it here. Would you mind double checking if it makes sense to have My understanding of that test is that we validate that a consumer will resume from a committed offset, but |
Caching improvements in a number of places:
MemoizingPerInstantiationSerializableSupplier
utility class.This results in a significant reduction of processing consumers (before: consumer per split per process element per worker, after: consumer per split per worker). Processing consumers are evicted if they're eligible for collection and are more likely to close their connections after
connections.max.idle.ms
.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.