-
Notifications
You must be signed in to change notification settings - Fork 1k
Build Nouveau on Windows #4678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Nouveau on Windows #4678
Conversation
Update: A file handle to |
10ba201
to
2c518db
Compare
Fixed the open file handle issue by commit b7ca600. Commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The changes look good based on the diff. I didn't run it on Windows. It looks like you did and it worked, so I think that's good enough.
Thanks Nick, if you have time, you can test it before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@big-r81 since you insisted, as rightly you should have :-) I have tested the PR on the windows CI machine (on my own clone of couchdb).
+1

Thanks keeping it updated
The default node name in configure.ps1 changed in apache#4678, from couchdb@localhost to [email protected] This change in behaviour also occurred in When upgrading from 2.x to 2.1.1, so the upgrade notes for 3.4.x have been updated with the same text. https://docs.couchdb.org/en/stable/whatsnew/2.1.html#upgrade-notes
The default node name in configure.ps1 changed in apache#4678, from couchdb@localhost to [email protected] The same change in default node name (and resulting behaviour) also occurred in "When upgrading from 2.x to 2.1.1", so the upgrade notes for 3.4.x have been updated with the same text. https://docs.couchdb.org/en/stable/whatsnew/2.1.html#upgrade-notes
The default node name in configure.ps1 changed in apache#4678, from couchdb@localhost to [email protected] The same change in default node name (and resulting behaviour) also occurred in "When upgrading from 2.x to 2.1.1", so the upgrade notes for 3.4.x have been updated with the same text. https://docs.couchdb.org/en/stable/whatsnew/2.1.html#upgrade-notes
Porting Nouveau to build on Windows.
Commands:
The clean target ends with the following error:
It seems, nouveau isn't shutting down properly by our
dev/run
script. Needs additional investigation.