-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Enhancement] (nereids)implement showColumnStatsCommand in nereids #45439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
1 similar comment
run buildall |
return new ShowColumnStatsCommand(new TableNameInfo(tableNameParts), colNames, partitionNames, isCached); | ||
} | ||
|
||
private PartitionNames parsePartitionSpec(PartitionSpecContext ctx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a visitPartitionSpec method already, please use it instead of creating a new one. Take bellow as example:
Pair<Boolean, List<String>> partitionSpec = visitPartitionSpec(ctx.partitions);
PartitionNamesInfo partitionNames = new PartitionNamesInfo(partitionSpec.first, partitionSpec.second);
|
||
private final TableNameInfo tableName; | ||
private final List<String> columnNames; | ||
private final PartitionNames partitionNames; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private final PartitionNames partitionNames; | |
private final PartitionNamesInfo partitionNames; |
use PartitionNamesInfo instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - pls review
analyze(); | ||
} | ||
|
||
public void analyze() throws AnalysisException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use PartitionNamesInfo, PartitionNames don't need to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done - please review
c52a5c5
to
9367eb9
Compare
run buildall |
TPC-H: Total hot run time: 39896 ms
|
TPC-DS: Total hot run time: 189738 ms
|
ClickBench: Total hot run time: 32.98 s
|
9367eb9
to
c3e07ca
Compare
run buildall |
TPC-H: Total hot run time: 39693 ms
|
TPC-DS: Total hot run time: 195779 ms
|
ClickBench: Total hot run time: 33.17 s
|
run buildall |
TPC-H: Total hot run time: 39966 ms
|
TPC-DS: Total hot run time: 197126 ms
|
ClickBench: Total hot run time: 32.12 s
|
run buildall |
TPC-H: Total hot run time: 32508 ms
|
TPC-DS: Total hot run time: 196811 ms
|
ClickBench: Total hot run time: 31.28 s
|
run buildall |
9efaab9
to
fff177f
Compare
run buildall |
fff177f
to
55594e0
Compare
run buildall |
run buildall |
TPC-H: Total hot run time: 34041 ms
|
TPC-DS: Total hot run time: 192416 ms
|
ClickBench: Total hot run time: 31.59 s
|
fd151f8
to
2ff8eee
Compare
run buildall |
1 similar comment
run buildall |
08745ac
to
6b86d32
Compare
run buildall |
TPC-H: Total hot run time: 34464 ms
|
TPC-DS: Total hot run time: 192203 ms
|
ClickBench: Total hot run time: 28.56 s
|
6b86d32
to
6dc07ae
Compare
run buildall |
TPC-H: Total hot run time: 34014 ms
|
TPC-DS: Total hot run time: 193793 ms
|
ClickBench: Total hot run time: 28.72 s
|
6dc07ae
to
775a312
Compare
run buildall |
775a312
to
d1ed20b
Compare
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 33097 ms
|
TPC-DS: Total hot run time: 187192 ms
|
ClickBench: Total hot run time: 29.13 s
|
FE UT Coverage ReportIncrement line coverage |
What problem does this PR solve?
Issue Number: close #42717
Related PR: #xxx
Problem Summary:
[Enhancement] (nereids)implement showColumnStatsCommand in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)