Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 25, 2025

No description provided.

@elharo elharo requested a review from michael-o April 25, 2025 12:08
<defaultValue>2.0</defaultValue>
<description><![CDATA[
For a plugin project (packaging is {@code maven-plugin}), the minimum version of
Maven required to use the resulting plugin.<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove <br> if there is no longer another paragraph after it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<type>String</type>
<defaultValue>2.0</defaultValue>
<description><![CDATA[
For a plugin project (packaging is {@code maven-plugin}), the minimum version of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't <defaultValue>2.0</defaultValue> (two lines up) be changed to <defaultValue>3.0</defaultValue> then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I'd rather avoid any change of default values in model 4.0.0. But maybe we could change the default to 4.0 for model 4.1.0. Though this may not be possible to do that in the parser. So not sure it's worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, but this is a doc only change. Code changes need a separate issue and PR.

@elharo elharo merged commit 3330cdb into master Apr 29, 2025
19 checks passed
@elharo elharo deleted the MNG-8240 branch April 29, 2025 12:45
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants