-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MNGSITE-393] Remove Maven 1 and 2 references #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<defaultValue>2.0</defaultValue> | ||
<description><![CDATA[ | ||
For a plugin project (packaging is {@code maven-plugin}), the minimum version of | ||
Maven required to use the resulting plugin.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove <br>
if there is no longer another paragraph after it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
<type>String</type> | ||
<defaultValue>2.0</defaultValue> | ||
<description><![CDATA[ | ||
For a plugin project (packaging is {@code maven-plugin}), the minimum version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't <defaultValue>2.0</defaultValue>
(two lines up) be changed to <defaultValue>3.0</defaultValue>
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I'd rather avoid any change of default values in model 4.0.0. But maybe we could change the default to 4.0
for model 4.1.0
. Though this may not be possible to do that in the parser. So not sure it's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, but this is a doc only change. Code changes need a separate issue and PR.
No description provided.