[MNG-8746] Preserve property insertion order in WrapperProperties

[gnodet]

Description

This PR fixes MNG-8746 by implementing property insertion order preservation in Maven's WrapperProperties class. The issue was that properties accessed through model.getProperties() were not maintaining their insertion order, leading to inconsistent behavior.

Problem

The WrapperProperties class in the Maven compat layer was not preserving the insertion order of properties. When properties were added through the Properties API and then accessed via methods like keySet() or entrySet(), they would be returned in an arbitrary order (often alphabetical) rather than the order they were inserted.

Solution

Implemented a comprehensive order preservation mechanism:

Key Changes:

1. Enhanced WrapperProperties Template (src/mdo/java/WrapperProperties.java):

   • Added internal OrderedProperties class that maintains insertion order
   • Implemented caching mechanism to preserve order across read/write operations
   • Modified all read operations to use the ordered cache
   • Simplified write operations to work directly with the ordered properties

2. OrderedProperties Implementation:

   • Uses ArrayList<Object> keyOrder to track key insertion order
   • Overrides put(), setProperty(), and remove() methods to maintain order
   • Custom KeySet and EntrySet implementations that iterate in insertion order
   • Removed unnecessary synchronized wrappers that interfered with ordering

3. Architecture Simplification:

   • WrapperProperties maintains its own ordered state independently
   • Only syncs content (not order) with the v4 API model when needed
   • Eliminated complex cache invalidation logic that was causing order loss

Testing

Added comprehensive tests:

• PropertiesOrderTest: Tests v4 API model order preservation
• WrapperPropertiesOrderTest: Tests compat layer order preservation
• Covers various scenarios including property modification and initial properties

Verification

The implementation ensures that:

Properties props = model.getProperties();
props.setProperty("key3", "value3");
props.setProperty("key1", "value1");
props.setProperty("key2", "value2");

// keySet() now returns ["key3", "key1", "key2"] in insertion order
// instead of ["key1", "key2", "key3"] in alphabetical order

Impact

• ✅ Preserves property insertion order for consistent behavior
• ✅ Maintains backward compatibility
• ✅ No breaking changes to existing APIs
• ✅ Improves reproducible builds

Fixes: https://issues.apache.org/jira/browse/MNG-8746

---

Pull Request opened by Augment Code with guidance from the PR author

[Pankraz76]

can we use PostConstruct ?

[jira-importer]

Resolve #9550