[SPARK-47497][SQL][FOLLOWUP] Add a UT for nested structure for the function to_csv - #45692
Closed
panbingkun wants to merge 1 commit into
Closed
[SPARK-47497][SQL][FOLLOWUP] Add a UT for nested structure for the function to_csv#45692panbingkun wants to merge 1 commit into
nested structure for the function to_csv#45692panbingkun wants to merge 1 commit into
Conversation
panbingkun
changed the title
nested structurenested structure for the function to_csv
panbingkun
marked this pull request as ready for review
March 25, 2024 07:59
Contributor
Author
|
cc @LuciferYang |
LuciferYang
approved these changes
Mar 25, 2024
LuciferYang
left a comment
LuciferYang
left a comment
Contributor
There was a problem hiding this comment.
+1, LGTM (pending test)
also cc @cloud-fan
HyukjinKwon
reviewed
Mar 25, 2024
| val df = spark.createDataFrame(rows, schema) | ||
| val actual1 = df.select(to_csv($"value")) | ||
| checkAnswer(actual1, Row("2,Alice," + | ||
| "\"[{math -> 100, english -> 200, science ->}, " + |
Member
There was a problem hiding this comment.
Are we really going to settle this down as a formal behaviour? Is this upported in Spark Connect with Scala client?
Contributor
Author
There was a problem hiding this comment.
Yes, this be supported in Spark Connect with Scala client, double-check as follows:
Member
There was a problem hiding this comment.
What about Spark Connect with Python?
cloud-fan
approved these changes
Mar 25, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add a UT for
nested structurefor the functionto_csv.FollowUp: #45657
Why are the changes needed?
Add a UT, improve test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.