[SPARK-45891][SQL][TESTS] Make VariantSuite test agnostic of the stableDerivedColumnAlias config - #49135
Closed
harshmotw-db wants to merge 7 commits into
Closed
Conversation
harshmotw-db
marked this pull request as ready for review
December 10, 2024 22:02
harshmotw-db
changed the title
harshmotw-db
changed the title
Contributor
Author
|
@MaxGekk Can you look at this PR since you implemented the |
HyukjinKwon
changed the title
cloud-fan
approved these changes
Dec 13, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make the "group/order/join variant are disabled" test in VariantSuite agnostic of the
spark.sql.stableDerivedColumnAlias.enabledconfig.Why are the changes needed?
Earlier, the suite would fail when
spark.sql.stableDerivedColumnAlias.enabledwas true since the column alias would be different.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.