-
-
Notifications
You must be signed in to change notification settings - Fork 934
fix(test): remove SerializerAwareProvider mechanism and related compiler pass #7314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinceAmstoutz
wants to merge
1
commit into
api-platform:main
Choose a base branch
from
vinceAmstoutz:fix/remove-private-service-phpstan-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(test): remove SerializerAwareProvider mechanism and related compiler pass #7314
vinceAmstoutz
wants to merge
1
commit into
api-platform:main
from
vinceAmstoutz:fix/remove-private-service-phpstan-error
+27
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2024aea
to
61d9cdc
Compare
soyuka
reviewed
Aug 18, 2025
…ler pass Fixes phpstan error ignored in the config.
61d9cdc
to
8ba7b41
Compare
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 22, 2025
…lizableProvider Violates the dependency injection principle. A PR for the removal was already made: api-platform#7314
@vincentchalamon @soyuka As described here, you can found the PR for the deprecation only here: #7348. If you want @soyuka we can keep this PR and merge it when we are ready (for e.g version 5.0). |
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 22, 2025
…lizableProvider A PR for the removal was already made: api-platform#7314.
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 22, 2025
…lizableProvider A PR for the removal was already made: api-platform#7314.
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 22, 2025
…lizableProvider A PR for the removal was already made: api-platform#7314.
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 26, 2025
…lizableProvider A PR for the removal was already made: api-platform#7314.
vinceAmstoutz
added a commit
to vinceAmstoutz/api-platform-core
that referenced
this pull request
Aug 26, 2025
…lizableProvider A PR for the removal was already made: api-platform#7314.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
Fixes phpstan error ignored in the config.