This repository was archived by the owner on Sep 6, 2021. It is now read-only.
fix: Allow # and @ in api param names
#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello, Thanks! I think it would be nice to include other characters too. |
Contributor
Author
|
Could you provide a list of characters that should be accepted ?
|
Collaborator
|
The |
Contributor
Author
|
Added the |
GentileFulvio
changed the title
# in api param names# and . in api param names
GentileFulvio
changed the title
# and . in api param names# and @ in api param names
Collaborator
|
Yes in fact the |
Collaborator
|
Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be honest not sure if you want this to be fixes but I had this issue mentioned here apidoc/apidoc#899 that I can't use
#'s in my param names. So I guess this fixes that.There is still a failing test also mentioned in the issue linked. Didn't want to touch it though because it's not really part of this commit/issue as this commit fixes a specific issue (The test was already broken before I added any changes). I added a new test files that explicitly tests the
api_paramparser instead which seemed easier than the other tests you already have in the project. Let me know what you think.Perhaps I should include other characters as well as mentioned in the following issues. #3 #64 #66