Skip to content

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Aug 4, 2023

Related: #661

@B4nan B4nan requested a review from barjin August 4, 2023 10:38
@B4nan B4nan added debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 4, 2023
@B4nan B4nan requested a review from metalwarrior665 August 4, 2023 10:43
@B4nan
Copy link
Member Author

B4nan commented Aug 4, 2023

cc @metalwarrior665, I've left only one occurence of the named import (import {load} from 'cheerio') as it was described in that specific section, so it felt fine, but we might wanna change that too.

https://docs.apify.com/academy/puppeteer-playwright/executing-scripts/collecting-data#parsing-in-node-context

@barjin
Copy link
Contributor

barjin commented Aug 4, 2023

There is a bunch of other places where the Cheerio imports are unused(?), I would vote for removing those altogether

@B4nan B4nan merged commit bf1af7b into master Aug 8, 2023
@B4nan B4nan deleted the cheerio-load branch August 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants