Skip to content

[table-driven-branch] Deinitialize and copy submessage fields. #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2025
Merged

[table-driven-branch] Deinitialize and copy submessage fields. #1869

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f7b8a2
[table-driven-branch] Deinitialize and copy submessage fields.
allevato Oct 14, 2025
563ccd1
[table-driven-branch] Update test protos and unit tests.
allevato Oct 14, 2025
9d2df92
[table-driven-branch] Update based on review feedback.
allevato Oct 14, 2025
846bdfc
[table-driven-branch] Update based on review feedback.
allevato Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions Tests/ExperimentalTableDrivenSwiftProtobufTests/Test_TableDriven.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,69 +25,116 @@ final class Test_TableDriven: XCTestCase {
msg.optionalBool = true
msg.optionalInt32 = 50
msg.optionalString = "some string"
msg.optionalImportMessage = .with { $0.d = 20 }
msg.repeatedInt32 = [1, 10, 100]
msg.repeatedString = ["a", "b", "c"]
msg.repeatedImportMessage = [
.with { $0.d = 10 },
.with { $0.d = 20 },
.with { $0.d = 30 },
]

XCTAssertEqual(msg.optionalBool, true)
XCTAssertEqual(msg.optionalInt32, 50)
XCTAssertEqual(msg.optionalString, "some string")
XCTAssertEqual(msg.optionalImportMessage.d, 20)
XCTAssertEqual(msg.repeatedInt32, [1, 10, 100])
XCTAssertEqual(msg.repeatedString, ["a", "b", "c"])
XCTAssertEqual(msg.repeatedImportMessage.count, 3)
XCTAssertEqual(msg.repeatedImportMessage[0].d, 10)
XCTAssertEqual(msg.repeatedImportMessage[1].d, 20)
XCTAssertEqual(msg.repeatedImportMessage[2].d, 30)
}

func testCopyAndModifyCopy() {
var msg = MessageTestType()
msg.optionalBool = true
msg.optionalInt32 = 50
msg.optionalString = "some string"
msg.optionalImportMessage = .with { $0.d = 20 }
msg.repeatedInt32 = [1, 10, 100]
msg.repeatedString = ["a", "b", "c"]
msg.repeatedImportMessage = [
.with { $0.d = 10 },
.with { $0.d = 20 },
.with { $0.d = 30 },
]

var msgCopy = msg
msgCopy.optionalBool = false
msgCopy.optionalInt32 = 100
msgCopy.optionalString = "other string"
msgCopy.optionalImportMessage.d = 99
msgCopy.repeatedInt32.append(1000)
msgCopy.repeatedString.removeLast()
msgCopy.repeatedImportMessage.removeLast()
msgCopy.repeatedImportMessage[0].d = 99

XCTAssertEqual(msg.optionalBool, true)
XCTAssertEqual(msg.optionalInt32, 50)
XCTAssertEqual(msg.optionalString, "some string")
XCTAssertEqual(msg.optionalImportMessage.d, 20)
XCTAssertEqual(msg.repeatedInt32, [1, 10, 100])
XCTAssertEqual(msg.repeatedString, ["a", "b", "c"])
XCTAssertEqual(msg.repeatedImportMessage.count, 3)
XCTAssertEqual(msg.repeatedImportMessage[0].d, 10)
XCTAssertEqual(msg.repeatedImportMessage[1].d, 20)
XCTAssertEqual(msg.repeatedImportMessage[2].d, 30)

XCTAssertEqual(msgCopy.optionalBool, false)
XCTAssertEqual(msgCopy.optionalInt32, 100)
XCTAssertEqual(msgCopy.optionalString, "other string")
XCTAssertEqual(msgCopy.optionalImportMessage.d, 99)
XCTAssertEqual(msgCopy.repeatedInt32, [1, 10, 100, 1000])
XCTAssertEqual(msgCopy.repeatedString, ["a", "b"])
XCTAssertEqual(msgCopy.repeatedImportMessage.count, 2)
XCTAssertEqual(msgCopy.repeatedImportMessage[0].d, 99)
XCTAssertEqual(msgCopy.repeatedImportMessage[1].d, 20)
}

func testCopyAndModifyOriginal() async throws {
var msg = MessageTestType()
msg.optionalBool = true
msg.optionalInt32 = 50
msg.optionalString = "some string"
msg.optionalImportMessage = .with { $0.d = 20 }
msg.repeatedInt32 = [1, 10, 100]
msg.repeatedString = ["a", "b", "c"]
msg.repeatedImportMessage = [
.with { $0.d = 10 },
.with { $0.d = 20 },
.with { $0.d = 30 },
]

let msgCopy = msg
msg.optionalBool = false
msg.optionalInt32 = 100
msg.optionalString = "other string"
msg.optionalImportMessage.d = 99
msg.repeatedInt32.append(1000)
msg.repeatedString.removeLast()
msg.repeatedImportMessage.removeLast()
msg.repeatedImportMessage[0].d = 99

XCTAssertEqual(msgCopy.optionalBool, true)
XCTAssertEqual(msgCopy.optionalInt32, 50)
XCTAssertEqual(msgCopy.optionalString, "some string")
XCTAssertEqual(msgCopy.optionalImportMessage.d, 20)
XCTAssertEqual(msgCopy.repeatedInt32, [1, 10, 100])
XCTAssertEqual(msgCopy.repeatedString, ["a", "b", "c"])
XCTAssertEqual(msgCopy.repeatedImportMessage.count, 3)
XCTAssertEqual(msgCopy.repeatedImportMessage[0].d, 10)
XCTAssertEqual(msgCopy.repeatedImportMessage[1].d, 20)
XCTAssertEqual(msgCopy.repeatedImportMessage[2].d, 30)

XCTAssertEqual(msg.optionalBool, false)
XCTAssertEqual(msg.optionalInt32, 100)
XCTAssertEqual(msg.optionalString, "other string")
XCTAssertEqual(msg.optionalImportMessage.d, 99)
XCTAssertEqual(msg.repeatedInt32, [1, 10, 100, 1000])
XCTAssertEqual(msg.repeatedString, ["a", "b"])
XCTAssertEqual(msg.repeatedImportMessage.count, 2)
XCTAssertEqual(msg.repeatedImportMessage[0].d, 99)
XCTAssertEqual(msg.repeatedImportMessage[1].d, 20)
}
}
Loading
Loading