-
Notifications
You must be signed in to change notification settings - Fork 18
Readd Travis support and update documentation #30
Conversation
Provide example .travis.yml to verify Travis integration.
|
The project was migrated from Travis to Circle. See f9eaf75 I don't think this is the problem |
|
After you commit something new, check the build here: https://travis-ci.org/codacy/php-codacy-coverage |
Trigger a rebuild by updating the docs.
|
Can you update the travis file to look like the one pointed by @haffla ? Something like: |
|
Please see my latest comment in #29 |
|
@ottlinger I don't really understand the aim of your PR. The And why is |
|
@haffla The travis build does not fail anymore, but no coverage results are transferred to Codacy without the API key. Since the documentation does not say how this key is configured in Travis I've added that part.
|
README.md
Outdated
| language: php | ||
|
|
||
| env: | ||
| - CODACY_PROJECT_TOKEN=<yourTokenGoesHere> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needs to be private. In circle ci they have a way to add it in the UI in travis they must have something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the documentation - thanks.
Since I've experienced build timeouts I'm in favour of keeping the retry option as it's recommended by Travis and prevents users from searching for it separately.
|
Sensible information like API keys should be made env vars as described here https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings. Regarding |
* Add howto set build specific environment variables.
|
@rtfpessoa would you mind accepting the PR after I've applied the changes? Thanks. |
|
I also do not think |
Remove travis_retry and add it to the documentation template.
|
The readme is still wrong. Sorry for te trouble the idea is just to have it as simple as possible. |
Remove travis_retry from MD.
|
@rtfpessoa sorry - corrected again. |
|
LGTM 👍 Also, thanks for the help @haffla |
|
Cheers Rodrigo, hope to see you soon! Say hello to everyone @codacy ;) |
|
Everyone here sends their best regards. Any plans to visit Lisbon? |
|
Quite likely this year, but nothing planned yet. Man what I miss most is that place where you always have lunch... the foooood. Hehehe see you! |
#29
Provide example .travis.yml to verify Travis integration.