Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

Conversation

@ottlinger
Copy link
Contributor

#29

Provide example .travis.yml to verify Travis integration.

Provide example .travis.yml to verify Travis integration.
@haffla
Copy link
Contributor

haffla commented Apr 4, 2017

The project was migrated from Travis to Circle. See f9eaf75

I don't think this is the problem

@rtfpessoa
Copy link
Contributor

After you commit something new, check the build here: https://travis-ci.org/codacy/php-codacy-coverage

Trigger a rebuild by updating the docs.
@rtfpessoa
Copy link
Contributor

Can you update the travis file to look like the one pointed by @haffla ?

Something like:

script:
   - php vendor/bin/phpunit
 
 after_script:
   - php bin/codacycoverage clover

@haffla
Copy link
Contributor

haffla commented Apr 4, 2017

Please see my latest comment in #29

#29
#30

Update example travis integration and mention how to submit the API key to Codacy.
@haffla
Copy link
Contributor

haffla commented Apr 4, 2017

@ottlinger I don't really understand the aim of your PR. The CODACY_PROJECT_TOKEN is your secret API token and should not go into version control. You should add this env variable in Travis where only you can see it.

And why is travis_retry necessary?

@ottlinger
Copy link
Contributor Author

@haffla The travis build does not fail anymore, but no coverage results are transferred to Codacy without the API key. Since the documentation does not say how this key is configured in Travis I've added that part.

Travis_retry is the recommended way to do things if relying on external stuff:
https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out

README.md Outdated
language: php

env:
- CODACY_PROJECT_TOKEN=<yourTokenGoesHere>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needs to be private. In circle ci they have a way to add it in the UI in travis they must have something similar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the documentation - thanks.
Since I've experienced build timeouts I'm in favour of keeping the retry option as it's recommended by Travis and prevents users from searching for it separately.

@haffla
Copy link
Contributor

haffla commented Apr 4, 2017

Sensible information like API keys should be made env vars as described here https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings.

Regarding travis-retry, I don't see the need as long as one does not experience timeouts.

* Add howto set build specific environment variables.
@ottlinger ottlinger changed the title Add Travis support Readd Travis support and update documentation Apr 4, 2017
@ottlinger
Copy link
Contributor Author

@rtfpessoa would you mind accepting the PR after I've applied the changes? Thanks.

@rtfpessoa
Copy link
Contributor

I also do not think travis_retry is a nice to have. People will just use it blindly and with no idea what it does.

Remove travis_retry and add it to the documentation template.
@rtfpessoa
Copy link
Contributor

The readme is still wrong. Sorry for te trouble the idea is just to have it as simple as possible.

Remove travis_retry from MD.
@ottlinger
Copy link
Contributor Author

@rtfpessoa sorry - corrected again.

@rtfpessoa
Copy link
Contributor

LGTM 👍

Also, thanks for the help @haffla

@rtfpessoa rtfpessoa merged commit 194b838 into archived-codacy:master Apr 5, 2017
@haffla
Copy link
Contributor

haffla commented Apr 5, 2017

Cheers Rodrigo, hope to see you soon! Say hello to everyone @codacy ;)

@rtfpessoa
Copy link
Contributor

Everyone here sends their best regards. Any plans to visit Lisbon?

@haffla
Copy link
Contributor

haffla commented Apr 6, 2017

Quite likely this year, but nothing planned yet. Man what I miss most is that place where you always have lunch... the foooood. Hehehe see you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants