Skip to content

Make RS485Class a configurable argument for ModbusRTU* #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

facchinm
Copy link
Contributor

Can be changed by either the constructor or begin()

Ports and replaces #14

Can be changed by either the constructor or begin()

Ports and replaces #14
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ 1c51a13

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 +150 - +208 +0.52 - +0.73 🔺 +4 - +57 +0.16 - +2.23
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:nano33ble 💚 -64 - 0 -0.01 - 0.0 🔺 +8 - +8 0.0 - 0.0
arduino:megaavr:uno2018:mode=off 🔺 +146 - +206 +0.3 - +0.42 🔺 +4 - +31 +0.07 - +0.5
arduino:samd:mkrwifi1010 🔺 0 - +8 0.0 - 0.0 🔺 +8 - +8 +0.02 - +0.02
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash
% examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables
% examples/RTU/ModbusRTUClientToggle
flash
% examples/RTU/ModbusRTUClientToggle
RAM for global variables
% examples/RTU/ModbusRTUServerKitchenSink
flash
% examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables
% examples/RTU/ModbusRTUServerLED
flash
% examples/RTU/ModbusRTUServerLED
RAM for global variables
% examples/RTU/ModbusRTUTemperatureSensor
flash
% examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables
% examples/TCP/EthernetModbusClientToggle
flash
% examples/TCP/EthernetModbusClientToggle
RAM for global variables
% examples/TCP/EthernetModbusServerLED
flash
% examples/TCP/EthernetModbusServerLED
RAM for global variables
% examples/TCP/WiFiModbusClientToggle
flash
% examples/TCP/WiFiModbusClientToggle
RAM for global variables
% examples/TCP/WiFiModbusServerLED
flash
% examples/TCP/WiFiModbusServerLED
RAM for global variables
%
arduino:avr:leonardo 150 0.52 4 0.16 150 0.52 4 0.16 150 0.52 4 0.16 150 0.52 4 0.16 178 0.62 4 0.16 208 0.73 57 2.23 208 0.73 57 2.23
arduino:mbed:envie_m7 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0
arduino:mbed:nano33ble 0 0.0 8 0.0 0 0.0 8 0.0 -64 -0.01 8 0.0 -64 -0.01 8 0.0 0 0.0 8 0.0
arduino:megaavr:uno2018:mode=off 146 0.3 4 0.07 146 0.3 4 0.07 146 0.3 4 0.07 146 0.3 4 0.07 170 0.35 4 0.07 186 0.38 31 0.5 206 0.42 31 0.5 194 0.4 31 0.5 186 0.38 31 0.5
arduino:samd:mkrwifi1010 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 0 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02
Click for full report CSV
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,150,0.52,4,0.16,150,0.52,4,0.16,150,0.52,4,0.16,150,0.52,4,0.16,178,0.62,4,0.16,208,0.73,57,2.23,208,0.73,57,2.23
arduino:mbed:envie_m7,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,,,,,,,,
arduino:mbed:nano33ble,0,0.0,8,0.0,0,0.0,8,0.0,-64,-0.01,8,0.0,-64,-0.01,8,0.0,0,0.0,8,0.0,,,,,,,,
arduino:megaavr:uno2018:mode=off,146,0.3,4,0.07,146,0.3,4,0.07,146,0.3,4,0.07,146,0.3,4,0.07,170,0.35,4,0.07,186,0.38,31,0.5,206,0.42,31,0.5,194,0.4,31,0.5,186,0.38,31,0.5
arduino:samd:mkrwifi1010,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02

@facchinm facchinm requested a review from Rocketct May 12, 2021 12:52
@facchinm facchinm merged commit 7904f40 into master May 25, 2021
@per1234 per1234 deleted the configurable_rs485_object branch November 19, 2021 01:44
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants