Skip to content

Add unit and integration testing for the sketch recursive load functionality #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 30, 2019
Merged

Add unit and integration testing for the sketch recursive load functionality #462

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebca955
add testcases to cover https://github.com/arduino/arduino-cli/issues/…
Oct 29, 2019
f1c28ff
add test to check error throw on symlink loop detection
Oct 29, 2019
7f66563
create symlink via test code to ensure cross platform creation
Oct 30, 2019
1ea0685
fixed assert to make the check cross platform
Oct 30, 2019
3d63c78
fixed all symlink check asserts to make the check cross platform
Oct 30, 2019
3db1dc9
nitpicking
Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nitpicking
  • Loading branch information
Roberto Sora committed Oct 30, 2019
commit 3db1dc953b71f4415c4d3c5959c56254f0fdbf5d
8 changes: 3 additions & 5 deletions test/test_compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_compile_with_simple_sketch(run_command, data_dir):
result = run_command("core update-index")
assert result.ok

# # Download latest AVR
# Download latest AVR
result = run_command("core install arduino:avr")
assert result.ok

Expand Down Expand Up @@ -75,7 +75,7 @@ def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
result = run_command("core update-index")
assert result.ok

# # Download latest AVR
# Download latest AVR
result = run_command("core install arduino:avr")
assert result.ok

Expand All @@ -98,9 +98,7 @@ def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
fqbn=fqbn, sketch_path=sketch_path))
# The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
# returning a different error detailed message
assert "Error during sketch processing" \
"".format(
loop_file_path=loop_file_path) in result.stderr
assert "Error during sketch processing" in result.stderr
assert not result.ok

sketch_name = "CompileIntegrationTestSymlinkDirLoop"
Expand Down