Skip to content

Programmers can't be listed anymore using burn-bootloader programmer … #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Programmers can't be listed anymore using burn-bootloader programmer … #982

merged 1 commit into from
Oct 5, 2020

Conversation

silvanocerza
Copy link
Contributor

…flag

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
    Removes a hackish way to list programmers and updates upload command documentation.
  • What is the current behavior?
    Calling the burn-bootloader command with the -P list flag returns a list of programmers.
  • What is the new behavior?
    Calling the burn-bootloader command with the -P list flag doesn't work anymore, the right way to do it is calling board details <fqbn> --list-programmers.
  • Does this PR introduce a breaking change?
    Yes.
  • Other information:
    None.

See how to contribute

@silvanocerza silvanocerza added topic: documentation Related to documentation for the project component/CLI labels Sep 25, 2020
@silvanocerza silvanocerza self-assigned this Sep 25, 2020
@silvanocerza
Copy link
Contributor Author

This fixes #967.

ubidefeo
ubidefeo approved these changes Sep 25, 2020
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected and leftover parts have been removed

@silvanocerza silvanocerza merged commit a8985da into master Oct 5, 2020
@silvanocerza silvanocerza deleted the scerza/programmers-list branch October 5, 2020 09:16
@per1234 per1234 mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

@rsora rsora Awaiting requested review from rsora

Assignees

@silvanocerza silvanocerza

Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @ubidefeo