Updated logic to extract the file extension #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some boards (namely ESP32 S3 Dev Kit) the command line coming from the Arduino compute endpoint contains more occurrences of
{build.project_name}
, e.g. something like{build.project_name}.bootloader.bin [...] {build.project_name}.bin
.In order to support these boards, we have to pick (by convention) the last occurrence, since it's what we use internally to retrieve the right file extension (in this case
bin
). Otherwise, in the example above, the file extension will beboo
from.bootloader
.NOTE: we could even improve this logic using a simple regular expression, something like
\{build\.project_name\}\.(\w\w\w)\b
, and then extract the extension which matches(\w\w\w)