Skip to content

Add CI workflow to check Markdown files for problems #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?

Infrastructure enhancement

  • What is the current behavior?

Markdown files are not being checked.

  • What is the new behavior?

On every push and pull request that affects relevant files, and periodically, check the repository's Markdown files for
problems:

The Arduino tooling Markdown style is defined by the .markdownlint.yml file.

In the event the repository contains externally maintained Markdown files, markdownlint can be configured to ignore them via a .markdownlintignore file:
https://github.com/igorshubovych/markdownlint-cli#ignoring-files

markdown-link-check is configured via the .markdown-link-check.json file:
https://github.com/tcort/markdown-link-check#config-file-format

  • Other information:

The task docs:generate has been emptied because it was depending on go:cli-docs and protoc:docs, which led to error messages when running task markdown:check-links.


@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Aug 4, 2022
@MatteoPologruto MatteoPologruto self-assigned this Aug 4, 2022
On every push and pull request that affects relevant files, and periodically, check the repository's Markdown files for
problems:

- Use markdownlint to check for common problems and formatting.
- Use markdown-link-check to check for broken links.

The Arduino tooling Markdown style is defined by the  file.

In the event the repository contains externally maintained Markdown files, markdownlint can be configured to ignore them
via a  file:
https://github.com/igorshubovych/markdownlint-cli#ignoring-files

markdown-link-check is configured via the  file:
https://github.com/tcort/markdown-link-check#config-file-format
@cmaglie cmaglie merged commit 31207da into main Aug 4, 2022
@cmaglie cmaglie deleted the check-markdown branch August 4, 2022 12:46
@MatteoPologruto MatteoPologruto changed the title Check markdown Add CI workflow to check Markdown files for problems Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants