Skip to content

Remove extra quotation marks from isWhitespace() #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Remove extra quotation marks from isWhitespace() #268

merged 1 commit into from
Mar 21, 2018

Conversation

PeterTillema
Copy link
Contributor

No description provided.

@per1234
Copy link
Collaborator

per1234 commented Nov 24, 2017

From the style guide:
https://raw.githubusercontent.com/arduino/reference-en/master/AsciiDoc_sample/Reference_Terms/AsciiDoc_Template-Single_Entity.adoc

It looks like the convention is to leave the quotes and instead to remove the code block markup (so delete lines 28 and 30).

I think that looks better too because it's kind of awkward to have a code block for one short line of code.

@SimonePDA
Copy link

I agree with Per1234 comment. Please fix the edit as suggested.

@per1234 per1234 mentioned this pull request Dec 20, 2017
@kengdahl kengdahl merged commit fe6e071 into arduino:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants